Bump monitor API version #4507
Open
Bump monitor API version #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiBarbuOz
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
AndreiBarbuOz
force-pushed
the
chore/bump-monitor-api-version
branch
from
d13237b to
dc357be
Compare
|
@microsoft-github-policy-service agree company="UiPath" |
super-harsh
reviewed
Jan 6, 2025
v2/samples/insights/v1api/v1api20240101preview_scheduledqueryrule.yaml
Outdated
Show resolved
Hide resolved
v2/samples/insights/v1api/v1api20240101preview_scheduledqueryrule.yaml
Outdated
Show resolved
Hide resolved
AndreiBarbuOz
force-pushed
the
chore/bump-monitor-api-version
branch
from
771df97 to
7884677
Compare
super-harsh
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Looks good! Just a minor thing without which CI won't pass is that you're missing a recording for sample test. You can run TEST_FILTER=Test_Samples_CreationAndDeletion task controller:test-integration-envtest command in root which'll test your latest sample(s) and create a recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update the version of the
Microsoft.Insights/scheduledQueryRulesto catch up with https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/change-log/scheduledqueryrules#2024-01-01-previewThe new version comes with some features, including the addition of a
.spec.identityfield which allows using an existing user assignment identity when the service executes the query. This was captured in a focused test, which creates the necessary prerequisites before instantiating the object.How does this PR make you feel?
Checklist