Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New module avm/ptn/mgmt-groups/subscription-placement #3904

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

31Nick
Copy link

@31Nick 31Nick commented Dec 9, 2024

Description

Adding the sub-placement pattern module

Closes Azure/Azure-Verified-Modules#1585 (comment)

Pipeline Reference

Pipeline
avm.ptn.mgmt-groups.subscription-placement

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • @avm-core-team-technical-bicep TODO: Add custom secret 'subscriptionBillingScope', 'rootManagementGroupId' ; to AVM CI

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 9, 2024
@oZakari oZakari changed the title Sub placement development feat: Sub placement development Dec 12, 2024
@oZakari
Copy link
Contributor

oZakari commented Jan 13, 2025

Thanks @AlexanderSehr! I misread that in the docs and once I moved them to the variables section they were getting pulled in correctly.

@oZakari
Copy link
Contributor

oZakari commented Jan 17, 2025

Hi @31Nick, I fixed the deployment in my branch and switched out the status badge. Can you just accept the GitHub license mentioned in the comments above? After that we should be good to go.

@oZakari oZakari marked this pull request as ready for review January 17, 2025 04:50
@oZakari oZakari requested review from a team as code owners January 17, 2025 04:50
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 17, 2025
@AlexanderSehr AlexanderSehr added the Class: Pattern Module 📦 This is a pattern module label Jan 17, 2025
@31Nick
Copy link
Author

31Nick commented Jan 22, 2025

@microsoft-github-policy-service agree company="Microsoft"

@eriqua eriqua changed the title feat: Sub placement development feat: New module .gfeat: New module avm.ptn/mgmt-groups/subscription-placement` Jan 26, 2025
@eriqua eriqua changed the title feat: New module .gfeat: New module avm.ptn/mgmt-groups/subscription-placement` feat: New module avm.ptn/mgmt-groups/subscription-placement Jan 26, 2025
@eriqua eriqua removed the Needs: Triage 🔍 Maintainers need to triage still label Jan 26, 2025
@eriqua eriqua changed the title feat: New module avm.ptn/mgmt-groups/subscription-placement feat: New module avm/ptn/mgmt-groups/subscription-placement Jan 26, 2025
@oZakari oZakari force-pushed the sub-placement-development branch from 4bd9be7 to 45e43a3 Compare January 27, 2025 06:31
@oZakari oZakari force-pushed the sub-placement-development branch from dcad1e5 to 827cc02 Compare January 27, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: avm/ptn/mgmt-groups/subscription-placement
5 participants