Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update avm/res/net-app/net-app-account - Backup module updated #4256

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Salima-90
Copy link
Contributor

@Salima-90 Salima-90 commented Jan 20, 2025

Description

Pipeline Reference

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@Salima-90 Salima-90 requested review from a team as code owners January 20, 2025 16:45
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Jan 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 20, 2025
@Salima-90 Salima-90 changed the title Feat netapps backup module updated Feat: netapps backup module updated Jan 21, 2025
@Salima-90 Salima-90 changed the title Feat: netapps backup module updated feat: netapps backup module updated Jan 21, 2025
@eriqua eriqua changed the title feat: netapps backup module updated feat: Update avm/res/net-app/net-app-account - Backup module updated Jan 26, 2025
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 26, 2025
@AlexanderSehr
Copy link
Contributor

He @Salima-90, thank you for your PR. Please note that there is already another active PR (#4043) which will conflict with this one given both suggest numerous changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants