Feature: Add functionality to /simulation/:id path #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce UpdateSimulationConfiguration schema because spawner isn't required when updating the simulation configuration.
Extract utility functions for creating simulations to reuse it for updating simulations
Initialize simulation configuration correctly by creating reference objects
Add duplicates of configuration objects to use them in update operation
We have to use the original celery worker, becuase the fixtures of celery aren't working properly. We can't mock the next_tick functions of the components, because they aren't forwarded to the celery worker. That's the reason why I had to skip tests connected to celery as long as we figure out why the celery fixtures aren't working properly.
5 tasks
3 tasks
antonykamp
requested review from
LucasDerReisende,
SaturnHafen,
Lietze,
CR1337 and
instant-sky
instant-sky
approved these changes
May 17, 2023
instant-sky
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
This PR adds the functionality to get, update, and remove a simulation configuration with the REST API.
While writing tests, I recognized a mistake in the simulation configuration fixtures. The result is that no fixtures were connected to the configurations, like spawner or fault configurations.
I tried to fix it but ran into a big problem with celery. We cannot pass mocks to the celery worker. I tried to use the fixtures of the worker and app provided by Celery, but they don't work properly. After a week of trying to fix it, I decided to skip every test connected to celery and create a new issue (see #469) .
PR checklist