Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC is not required in bioinfo_config until its implemented. Fixed datatypes #379

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Shettland
Copy link
Member

@Shettland Shettland commented Jan 29, 2025

Read-bioinfo-metadata was parsing integer IDs as floats sometimes, I changed an utils.py function to make it more consistent with datatypes.

Also changed "quality_control" key "required" to False in bioinfo_config.json until a way to obtain this data is implemented in buisciii-tools

Copy link
Member

@jaimeozaez jaimeozaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shettland Shettland merged commit 7865072 into BU-ISCIII:develop Jan 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants