Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store PotentialAdapters as Vec, not ArrayVec #534

Merged

Conversation

marceline-cramer
Copy link
Contributor

@marceline-cramer marceline-cramer commented Dec 6, 2023

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • relevant examples/test cases run
    • changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

Description

Storing PotentialAdapter in an ArrayVec goes out of bounds and panics when the system has more than 4 wgpu adapters available. Instead of increasing the capacity of the ArrayVec, I've simply converted it to a Vec instead.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow how did I think that would work....

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 6, 2023 21:50
@cwfitzgerald cwfitzgerald merged commit f820b98 into BVE-Reborn:trunk Dec 6, 2023
6 checks passed
@marceline-cramer marceline-cramer deleted the unbounded-potential-adapters branch December 7, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants