Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best effort error handling to mesh, skeleton, and texture creation #537

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • relevant examples/test cases run
    • changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

Closes #536

Description

This adds proper error detection to creation of mesh, skeleton, and texture creation. This should eliminate the majority of unexpected crashes from allocation failures.

Allocation failures that are handled by WebGPU itself cannot currently be handled due to the asynchronousness of errors. On native they will be caught as expected.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 11, 2023 02:49
@cwfitzgerald cwfitzgerald merged commit e1cfe1b into trunk Dec 11, 2023
6 checks passed
@cwfitzgerald cwfitzgerald deleted the error-handling branch December 12, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic, out of memory on mesh allocation
1 participant