Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StratOps (in particular Resupply helper methods) is showing high up in perf flame graphs of AI think time. Alot of time is spent:
To fix this:
GetAllFriendlies
&GetAllDetectedEnemies
methods already filter out dead and marked for death units, removed spots where the output of these methods is filtered via linq on these same criteria, avoiding a new enumerable being created, filtered and calls that consume time checking if a unit is dead.Overall the hope is that this creates a noticable improvement to combat/AI perf.
Notes for future:
GetAllFriendlies
&GetAllDetectedEnemies
, maybe caching or something? they are frequently called and do a fair number of checks and list creation overhead.