Improve Status performance with many ignored files #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix loading of `.gitignore` files in nested ignored directories. These were not matched in the current implementation, as that only checks the ignores of the current directory. As a side-effect this change also leads to significantly improved performance: in a repository with 3M ignored files `Status` now takes 160 s instead of 491 s.
silkeh
force-pushed
the
improve-ignored-status-performance
branch
from
999abb5 to
dce32ef
Compare
|
Note to the reviewer: Please close this PR instead of merging it. I'll send it upstream afterwards. |
silkeh
force-pushed
the
improve-ignored-status-performance
branch
from
dce32ef to
841ef77
Compare
Skip ignored files when walking through the worktree. This signigifantly improves the performance of `Status()`: In a repository with 3M ignored files `Status` now takes 5 s instead of 160 s.
silkeh
force-pushed
the
improve-ignored-status-performance
branch
from
841ef77 to
25c3930
Compare
k-mooijman
approved these changes
Jan 14, 2025
JerHavBW
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes that significantly improve the performance of
WorkTree.Status()(from 491 s to 5 s):This signigifantly improves the performance of
Status():In a repository with 3M ignored files
Statusnow takes 5 s instead of 160 s..gitignorefiles in nested ignored directories.These were not matched in the current implementation, as that only checks the ignores of the current directory.
As a side-effect this change also leads to significantly improved performance: in a repository with 3M ignored files
Statusnow takes 160 s instead of 491 s.