Requester and RateLimitRequester refactor #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intention is to seperate the dependency injection friendly class from the singleton code
Not optimal
Closed
JanOuborny
requested review from
JanOuborny and
BenFradet
and removed request for
JanOuborny
|
Sorry for the late review, haven't found the time yet, planning on doing it over the weekend 👍 |
BenFradet
reviewed
Oct 7, 2017
| { new TimeSpan(1, 0, 0), 10 } | ||
| }); | ||
|
|
||
| var staticRateLimitProvider = new RateLimitProvider(new Dictionary<TimeSpan, int>{{new TimeSpan(1, 0, 0), 10}}); |
There was a problem hiding this comment.
could you limit the lines to 120 chars?
| { | ||
| HttpRequestMessage CreateGetRequest(Region region, string apiEndpoint, List<string> addedArguments, bool useHttps = true); | ||
|
|
||
| HttpRequestMessage CreatePostRequest<T>(Region region, string apiEndpoint, T body, List<string> addedArguments, bool useHttps); |
There was a problem hiding this comment.
should we have useHttps = true as a default here and below too?
| var basicRequester = new Requester(client, requestCreator, deserializer); | ||
| var riotRateLimitProvider = new RateLimitProvider(riotSharpOptions.RiotApi.RateLimits); | ||
|
|
||
|
|
There was a problem hiding this comment.
could we remove the double empty lines in this file
| } | ||
|
|
||
| public string CreatePostRequest(string relativeUrl, Region region, string body, | ||
| public T Post<T>(string relativeUrl, Region region, object body, |
There was a problem hiding this comment.
why an object body there? can't we parameterize over it?
| { | ||
| public class RequestContentSerializer : IRequestContentSerializer | ||
| { | ||
| public HttpContent Serialize(object body) |
There was a problem hiding this comment.
can't we parameterize over body here too?
| if (instance == null || Requesters.RiotApiRequester == null || | ||
| apiKey != Requesters.RiotApiRequester.ApiKey || | ||
| !rateLimits.Equals(Requesters.RiotApiRequester.RateLimits)) | ||
| { | ||
| instance = new RiotApi(apiKey, rateLimits); | ||
| } | ||
| return instance; | ||
| } */ |
There was a problem hiding this comment.
this was meant to get a new API if someone changes api key or rate limits in his code, I don't know if we should keep it
|
|
||
| requester = new RateLimitedRequester(basicRequester, rateLimitProvider); | ||
|
|
||
| Requesters.RiotApiRequester = (RateLimitedRequester) requester; |
| return await Task.Factory.StartNew(() => JsonConvert.DeserializeObject<Champion>(json)); | ||
| var url = PlatformRootUrl + ChampionsUrl + string.Format(IdUrl, championId); | ||
| return await requester.GetAsync<Champion>(url, region); | ||
|
|
| if (instance == null || | ||
| Requesters.StaticApiRequester == null || | ||
| apiKey != Requesters.StaticApiRequester.ApiKey) | ||
| if (instance == null || instanceApiKey != apiKey) |
There was a problem hiding this comment.
if we remove it from RiotApi we might as well remove it here
| apiKey != Requesters.TournamentApiRequester.ApiKey || | ||
| !rateLimits.Equals(Requesters.TournamentApiRequester.RateLimits)) | ||
| apiKey != instanceApiKey || | ||
| !rateLimits.Equals(instanceRateLimits)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated API classes to use new requester interfaces