feat: Use pyhf contrib download to get pallet from HEPData #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenGalewsky This is ready for review. |
* Update to v0.6.0 * Use compatible release syntax to ensure stable APIs
* Allows for getting everything cleanly from central location of HEPData repo for published analysis. * Adopt v0.6.0 infer API
matthewfeickert
force-pushed
the
feat/use-pyhf-contrib-download
branch
from
ca05bb1 to
98df1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pyhf'scontribextra as a requirement, and stipulates a compatible release withpyhfv0.6.0at the patch level of SemVer to ensure this API exists. It does so to take advantage of this to easily get the entirepyhfpallet from the central location of the published analysis HEPData repo. This places both the background only workspace JSON and the signal patchset in a user defined directoryand ensures all requirements are available at runtime for submission to FuncX. Additionally use compatible release syntax with all requirements in
requirements.txt.