Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FCL-0.6.1 #21

Closed
wants to merge 4 commits into from

Conversation

DmitryNeverov
Copy link

Hi @mmatl,

I wanted to use python bindings for the flexible collision library, but found that they are broken after fcl got updated to 0.6.0.
They had two major things changed:

  • Switched to Eigen for math operations
  • Reorganised source tree

I think I have sorted out that part and now it builds and test/test_fcl.py succeeds, but something more obscure might not be working properly.

Updated header file locations
Disabled functions not present in Eigen objects
Disabled distance function
Set Eigen scalar template parameter to `double` everywhere
Vector3, Matrix3, Quaternion and Transform
are now native Eigen objects in FCL,
so helper functions were changed accordingly.
distance function and its dependants.
Now the old test/* is passing.
@DmitryNeverov
Copy link
Author

Oh well, I should've looked at other PRs here...

@pgunn
Copy link

pgunn commented Jan 28, 2021

Hi,
Thanks for providing the PR - this helped us get it working locally on a Linux cluster, although I needed to make the following additional change as part of a pip/conda-based install:

cd ~/miniconda3/envs/trimesh/include/fcl/geometry
ln -s bvh BVH
cd

I'm not sure why there was a difference in capitalisation of the bvh directory (this is on Linux though; maybe OSX is case-insensitive?).

@mikedh
Copy link
Collaborator

mikedh commented Feb 22, 2022

Thanks for the PR! Now that #29 is merged and released, I think we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants