Allowed page changing from outside & Fixed all the typos #284
+44
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a property called `manuallyHandelPageChange` to totally control the page change from `onItemSelected`
|
@BilalShahid13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Dear,
In the Pull Request you will find 2 commits, one of them to allow the page changing from outside, and the second is just a fix for all the typos.
For the page changing, it was always handled automatically by the package from inside the class, my commit is adding a property called
manuallyHandelPageChangeto leave the control of page changing for the providedonItemSelectedcallback.I hope you find this helpful.
Good Luck ❤