check version of secp256k1 extension before using it #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably should also have secp256k1-php check the version of libsecp256k1 to be compatible ... |
|
Makes sense, right now there's very little tying all that together! Same goes for secp256k1-php checking libsecp256k1.. I don't think there's a version anywhere in the lib, so this library is tested against libsecp256k1 master, same with secp256k1-php. It either compiles or it doesn't.. I had a go at building against a version kept in the repository, but couldn't get it to work either: Bit-Wasp/secp256k1-php#38 A debian package would be great, but upstream has yet to release as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if we can place this in any other place that is less deep into the code...