Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-344: Fixtures adjustments #518

Merged
merged 22 commits into from
Aug 14, 2024

Conversation

jkindly
Copy link

@jkindly jkindly commented Aug 12, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no/
Related tickets OP-344
License MIT

@jkindly jkindly requested a review from senghe August 12, 2024 12:45
<join-table name="bitbag_cms_section_blocks">
<cascade>
<cascade-all />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove blocks when removing collection? I wouldn't do this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, when we remove collection, then only collection from the block is removed, not the whole block.

src/Resources/config/doctrine/Media.orm.xml Outdated Show resolved Hide resolved
src/Resources/config/services/form.xml Outdated Show resolved Hide resolved
src/Resources/config/services/form.xml Outdated Show resolved Hide resolved
src/Resources/translations/messages.en.yml Show resolved Hide resolved
@jkindly jkindly merged commit ae9fff2 into feature/OP-312-redesign-cms-plugin Aug 14, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants