Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op 557 Update plugin to sylius 2.0 #74

Merged
merged 16 commits into from
Feb 3, 2025
Merged

Conversation

MarcinSzczepanskiBitBag
Copy link
Contributor

Update Sylius Mailchimp Plugin to sylius 2.0

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
public/bitbag-mailchimp-plugin-newsletter.js Outdated Show resolved Hide resolved
templates/_subscribe.html.twig Outdated Show resolved Hide resolved
Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in advance, but please review the docs and change jquery call to vanilla JS.

@senghe senghe merged commit bb388b9 into master Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants