Sylius 2.0 upgrade #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
4ec348a to
87c52cd
Compare
tomkalon
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
704095d to
95d1abd
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
f3baf2c to
de59090
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
de59090 to
cbf730f
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
cbf730f to
182f4ae
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
16 times, most recently
from
795cd6f to
6a7f0e4
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
4 times, most recently
from
6713b09 to
b9b368c
Compare
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
b9b368c to
c9634fc
Compare
senghe
requested changes
Jan 14, 2025
| @@ -17,5 +16,10 @@ parameters: | |||
|
|
|||
| ignoreErrors: | |||
| - '/Parameter #1 \$configuration of method Symfony\\Component\\DependencyInjection\\Extension\\Extension::processConfiguration\(\) expects Symfony\\Component\\Config\\Definition\\ConfigurationInterface, Symfony\\Component\\Config\\Definition\\ConfigurationInterface\|null given\./' | |||
| - '#missingType.iterableValue#' | |||
| - '#missingType.generics#' | |||
| - '/Parameter #1 \$productRepository of method BitBag\\SyliusProductBundlePlugin\\Component\\Product\\AddToCartFormComponent::initializeProduct\(\) expects Sylius\\Component\\Core\\Repository\\ProductRepositoryInterface<Sylius\\Component\\Core\\Model\\ProductInterface>, Sylius\\Component\\Core\\Repository\\ProductRepositoryInterface<BitBag\\SyliusProductBundlePlugin\\Entity\\ProductInterface> given\./' | |||
There was a problem hiding this comment.
Do we really need so many errors ignored? Can't we handle them?
There was a problem hiding this comment.
I handled some of them.
| #[AsLiveComponent] | ||
| final class AddToCartFormComponent extends BaseAddToCartFormComponent | ||
| { | ||
| //TODO there should be decoration instead of extension ? To discuss |
There was a problem hiding this comment.
From my point of view extension is the correct way. Maybe you have different opinion?
There was a problem hiding this comment.
I do not have any preference, just wanted to highlight the comment
| use Webmozart\Assert\Assert; | ||
|
|
||
| #[AsMessageHandler] | ||
| final class AddProductBundleToCartHandler |
There was a problem hiding this comment.
I do not get, why this is written from scratch. Was this feature missing?
There was a problem hiding this comment.
It is some bug in git for me. That file existed from 2019 and I just edited that.
| "hydra:member": [ | ||
| { | ||
| "@id": "\/api\/v2\/admin\/product-bundles\/@integer@", | ||
| "@id": "\/api\/v2/admin\/product-bundles\/@integer@", |
There was a problem hiding this comment.
Why only one backslash has been removed?
| "inStock": true | ||
| }, | ||
| "productName": "Whiskey Double Pack", | ||
| "variant": "/api/v2/shop/product-variants/@string@", |
There was a problem hiding this comment.
So the "productBundleItems" is "hidden" here, am I right?
There was a problem hiding this comment.
Yes you are right.
| @@ -1 +1 @@ | |||
| import 'sylius/bundle/AdminBundle/Resources/private/entry'; | |||
| import 'sylius/bundle/AdminBundle/Resources/assets/entrypoint'; | |||
There was a problem hiding this comment.
Thats how sylius 2.0 need to do that
JanPalen
force-pushed
the
feature/OP-550-sylius-2.0-upgrade
branch
from
01b603b to
ed031a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade plugin to Sylius 2.0.