Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sign of res1 #198

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix the sign of res1 #198

merged 2 commits into from
Dec 26, 2024

Conversation

weikengchen
Copy link
Contributor

During the calculation of the constraint numerator, the sign for res1 is indeed wrong. This was not caught before because the res1 polynomial was "linear" in the case of the Fibonacci example and therefore would be simply zero everywhere.

This was caught during the implementation of the recursive verifier.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...dsl/plonk/part2_fiat_shamir2_and_constraint_num.rs 93.10% <ø> (ø)

@weikengchen weikengchen merged commit 68982ac into main Dec 26, 2024
8 checks passed
@weikengchen weikengchen deleted the fix-res1-sign branch December 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant