Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work for the Fibonacci demo prover #26

Conversation

weikengchen
Copy link
Contributor

Since we need to replace the channel, it seems to force us to copy-paste some code from stwo and make modifications over it.

In this PR, we will put those code under crate::stwo_fork, and we will revisit in a later day what changes should we suggest to stwo to avoid the need of forking (mostly due to hardcoded struct).

Some of the immediate next steps are labeled in the code as "TODO(Bitcoin)".

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/channel/bitcoin_script.rs 95.23% <100.00%> (+7.73%) ⬆️
src/circle/bitcoin_script.rs 100.00% <100.00%> (+18.18%) ⬆️
src/constraints/bitcoin_script.rs 100.00% <ø> (ø)
src/fri/bitcoin_script.rs 100.00% <100.00%> (+4.76%) ⬆️
src/fri/mod.rs 100.00% <ø> (ø)
src/lib.rs 50.00% <ø> (ø)
src/merkle_tree/bitcoin_script.rs 100.00% <ø> (ø)
src/merkle_tree/mod.rs 82.85% <ø> (+0.50%) ⬆️
src/oods/bitcoin_script.rs 100.00% <100.00%> (ø)
src/oods/mod.rs 100.00% <100.00%> (ø)
... and 3 more

@weikengchen
Copy link
Contributor Author

Relocating the stwo_fork to a separate repo, for two reasons:
(1) stwo's license is Apache2 while this repo's license is MIT, so it is not very suitable to mix them together
(2) coverage

@weikengchen weikengchen changed the title Start the Fibonacci demo prover work by copy-pasting some code Initial work for the Fibonacci demo prover May 31, 2024
Copy link
Collaborator

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weikengchen weikengchen merged commit 01836ef into Bitcoin-Wildlife-Sanctuary:main May 31, 2024
8 of 9 checks passed
@weikengchen weikengchen deleted the copy-stwo-fib-prove-verify branch May 31, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants