Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage #33

Merged

Conversation

weikengchen
Copy link
Contributor

This PR includes some code optimization and additional tests that increase the coverage.

There could be some chances to increase the coverage further---it might have something to do with the script language.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 57.69231% with 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/utils/bitcoin_script.rs 100.00% <ø> (ø)
src/utils/mod.rs 96.22% <100.00%> (-0.07%) ⬇️
src/channel/bitcoin_script.rs 44.11% <0.00%> (+1.69%) ⬆️
src/channel/mod.rs 50.00% <56.25%> (+5.81%) ⬆️

... and 3 files with indirect coverage changes

@weikengchen
Copy link
Contributor Author

A next step is to improve the husky by also checking the tests during clippy.

@weikengchen weikengchen merged commit c359130 into Bitcoin-Wildlife-Sanctuary:main Jun 3, 2024
7 checks passed
@weikengchen weikengchen deleted the increase-coverage branch June 3, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant