Use Safe SDK #15
Closed
Use Safe SDK #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bh2smith
commented
Jun 28, 2024
src/alt-safe.ts
Outdated
Comment on lines
81
to
94
| // This should be part of the kit! | ||
| export async function getSafeOpHash( | ||
| provider: ethers.JsonRpcProvider, | ||
| safeKit: Safe4337Pack, | ||
| safeOp: EthSafeOperation, | ||
| ) { | ||
| return calculateSafeUserOperationHash( | ||
| safeOp.data, | ||
| BigInt(await safeKit.getChainId()), | ||
| // The safe isn't deployed so we have to fetch the fallback Handler on our own: | ||
| // await safeKit.protocolKit.getFallbackHandler() | ||
| await getSafeModuleAddress(provider), | ||
| ); | ||
| } |
There was a problem hiding this comment.
This is the content of safe-global/safe-core-sdk#888
bh2smith
commented
Jun 28, 2024
src/alt-safe.ts
Outdated
| import { calculateSafeUserOperationHash } from "@safe-global/relay-kit/dist/src/packs/safe-4337/utils"; | ||
| import { ethers } from "ethers"; | ||
| import { getDeployment } from "./safe"; | ||
| import { getSafeModuleSetupDeployment } from "@safe-global/safe-modules-deployments"; |
There was a problem hiding this comment.
This should also be part of the kit.
bh2smith
commented
Jun 28, 2024
src/alt-safe.ts
Outdated
| @@ -0,0 +1,94 @@ | |||
| import SafeApiKit, { SafeInfoResponse } from "@safe-global/api-kit"; | |||
There was a problem hiding this comment.
Would love to have avoided this too... its a checky hack to determine if the safe the user wants to use exists already or not. This could be determined by the setup (i.e. seed) data.
|
Closing as "likely wont do" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to simplify the manually implemented
safe.tsin favour of relay-kit and (apparently also api-kit).There is a GIST here with some additional notes:
https://gist.github.com/bh2smith/27f177a627a0e8679847b857c4d40d66
The kit is not very user friendly and missing some features as of now.
Unfortunately, the signature appears to be invalid: I suspect its something to do with the way we "add signature".