Add missing TREAT, CAST and LITERAL functions #1933
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwgmeligmeyling
commented
Aug 29, 2024
Comment on lines
+11
to
+12
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> |
There was a problem hiding this comment.
Wasn't the whole project changed to Java 8 minimally already? I thought that was the blocker for TREAT_INSTANT and others to be added to begin with?
There was a problem hiding this comment.
It wasn't, the support of java.time types was doable without a hard dependency on Java 8. Version 2.0 which I'm working on currently will be based on Java 11 though, so we can get rid of some of the hacks.
There was a problem hiding this comment.
Ok, then we'll let this PR sit until 2.0 as well 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few more treat functions were added recently. I ended up needing them in the Querydsl integration so I decided to add them 😉
Description
Related Issue
Motivation and Context