Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint dropped courses #39

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wznmickey
Copy link
Contributor

Rebase #31 from 2.0.10 and take review into account.

@BoYanZh
Copy link
Owner

BoYanZh commented Sep 15, 2022

I think it will not raise an error as described in #26 now. Ignore the invalid course is enough.

@wznmickey
Copy link
Contributor Author

wznmickey commented Sep 15, 2022

I think it will not raise an error as described in #26 now. Ignore the invalid course is enough.

But each time the code running, there will be additional request to the server for each invalid course, which will increase the request rate that will make it more likely to be banned and waste server resources.

@BoYanZh
Copy link
Owner

BoYanZh commented Sep 16, 2022

Most requests come from listing files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants