Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom variable in .convertClonecall #301

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

noranekonobokkusu
Copy link
Contributor

This is a fix for #299 that allows a user to use custom variables of the combineTCR output to define clones.

@ncborcherding
Copy link
Member

Great let me run the workflows and will get it merged. We're in the starting a manuscript for the new scRepertore. I think you have had some great finds in terms of bugs, let me know if you have suggestions or other pull requests.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ce55335) 83.39% compared to head (2b8bb29) 83.81%.

Files Patch % Lines
R/utils.R 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   83.39%   83.81%   +0.42%     
==========================================
  Files          40       40              
  Lines        2932     2917      -15     
==========================================
  Hits         2445     2445              
+ Misses        487      472      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncborcherding ncborcherding merged commit e701198 into BorchLab:master Jan 4, 2024
3 of 4 checks passed
@noranekonobokkusu
Copy link
Contributor Author

@ncborcherding I do have some notes/questions/comments on several functions. Should I write them here as a list, or email them, or open new issues? For most of them, I cannot make pull requests right away as I don't know if the observed behavior of the function is intentional.

@ncborcherding
Copy link
Member

Feel free to send them along via email , happy to take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants