-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over quietT/BCRgenes()
#459
Conversation
@ncborcherding In the future when this version goes into the main bioconductor server, the sourcecode for those functions in Ibex and Trex can be removed and they can re-export those functions instead. |
quietT/BCRgenes()
and use checkout@v4
quietT/BCRgenes()
and use checkout@v4quietT/BCRgenes()
and add findVariableNonVdjFeatures()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncborcherding Ensure the new changelog info I added are in the correct location in NEWS.md?
@Qile0317 I don't think we can have functions that depend on Seurat - it is a massive dependency hole. I would prefer keeping everything to SeuratObject. Maybe we can keep the quiet functions and not have an independent variable gene function? |
@ncborcherding Right - so in this configuration Seurat is actually in Suggests and nothing from Seurat is actually loaded or imported. Rather the namespace is required to be loaded at runtime instead of package build time. Everything that was prefixed with |
Think we need to drop it as that is not in keeping with Bioconductor policy and they also want equal support for SingleCellExperiment. Lets just do the quiet() functions. Thanks, |
Ok, sounds good, will remove now. |
quietT/BCRgenes()
and add findVariableNonVdjFeatures()
quietT/BCRgenes()
copies over the
quietTCRgenes()
andquietBCRgenes()
functions from Trex and Ibex, and also adds a functionquietVDJgenes()
that runs both as a convenience. Lastly, some small changes are that all instances of the github checkout action has been upgraded to v4 from v3, and some redundant imports in DESCRIPTION have been trimmed.