Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding updates #226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivanvpan
Copy link

@ivanvpan ivanvpan commented Feb 2, 2025

No description provided.

Copy link

netlify bot commented Feb 2, 2025

👷 Deploy request for dapper-sundae-ae0873 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8ace891

@@ -0,0 +1 @@
stable
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minimum version of node for NextJS and I was below minimum. With this file running nvm use fixes the situation and is generally safe.


export const anvilConfig = getConfig(31337);

export const anvilAccounts: Array<Hex> = [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused.

"0xa0ee7a142d267c1f36714e4a8f75612f20a79720",
];
// Wrapped into a function so we do not initialize on import, before all contracts are deployed
export function getAnvilConfig() {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running into a problem: importing chainConfig.ts file required certain contracts are already deployed. Since when we run preDeploy those contracts do not exist I created "getters" for config so that importing chainConfig.ts does not blow things up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what was happening now 🙂

Copy link
Contributor

@secbajor secbajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanvpan nice - this looks good to me. i cloned it locally and went through the steps, all seems to work good altho i had some issues with dependencies, noted below.

when ive cloned this fork and run thru the setup steps i have to use pnpm exec next dev instead of just pnpm run dev due to an issue with the next dependency i havent been able to replicate nor resolve. i suspect this is something about my local setup, so not suggesting any changes to the PR but felt worth noting here.


Because of how the distributor contract works the developer wallet needs to hold some bread before we deploy the contracts for us to be able to vote. The setup script takes care of this as well as funding the wallet with LP tokens which is needed for the LP locking feature.
3. Because of how the distributor contract works the developer wallet needs to hold some bread before we deploy the contracts for us to be able to vote. The setup script takes care of this as well as funding the wallet with LP tokens which is needed for the LP locking feature.

```sh
$ pnpm run chain:setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cloned your fork to try this whole setup from a fresh start and noticed this setup step fails if tsx is not installed globally. so a suggestion to add a note here or above in the list of general dependencies, for installing tsx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that was happening for you as tsx is added as a dev dependency 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants