-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for the Divider widget #20
feat: Add support for the Divider widget #20
Conversation
Hey @bhattkrutij!! Analyze and format checks are failing. Can you please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR 🚀
Please check my suggested changes.
pubspec.yaml
Outdated
build_runner: ^2.4.14 | ||
dependencies: | ||
mirai: ^0.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add these dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divyanshub024 without it given error. to code.removed.
part 'mirai_divider.freezed.dart'; // Auto-generated Freezed file | ||
part 'mirai_divider.g.dart'; // Auto-generated JSON serialization file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 generated files are missing. We need to include them as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divyanshub024 added this.
@@ -77,3 +77,4 @@ export 'package:mirai/src/parsers/mirai_text_form_field/mirai_text_form_field.da | |||
export 'package:mirai/src/parsers/mirai_text_style/mirai_text_style.dart'; | |||
export 'package:mirai/src/parsers/mirai_theme/mirai_theme.dart'; | |||
export 'package:mirai/src/parsers/mirai_wrap/mirai_wrap.dart'; | |||
export 'package:mirai/src/parsers/mirai_divider/mirai_divider.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sort the imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divyanshub024 .Thanks for the guidance. i have pushed code with changes.
Thank you.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bhattkrutij |
I had run below commands |
❌ Deploy Preview for buildmirai failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @bhattkrutij 💯 🎉
thank you @divyanshub024 for giving me chance to work on this.looking forward to contribute more. |
Description
This PR introduces support for the Divider widget. It adds a new feature that allows the use of customizable dividers in the UI, including options for thickness, height, and color.This feature is useful for creating styled dividers in a server-driven UI, allowing dynamic customization based on JSON input.
Key changes:
Divider
widget with customizable properties (thickness, height, color).Related Issues
Closes #15
Type of Change