Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for mirai progress indicators #84

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

ishanvaghani
Copy link
Contributor

Added support for mirai progress indicators

Added CircularProgressIndicator support
Added LinearProgressIndicator support
Added Documentation for both indicators

Screenshots

XRecorder_05012025_112917.mp4

Related Issues

Issue is not listed

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@divyanshub024
Copy link
Member

@ishanvaghani This is excellent PR. Thank you so much!! 💯
There is some formatting issue. Can you please check?

@ishanvaghani
Copy link
Contributor Author

@ishanvaghani This is excellent PR. Thank you so much!! 💯 There is some formatting issue. Can you please check?

@divyanshub024 Pushed the formatting changes 🙂

Copy link
Member

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this amazing PR @ishanvaghani 🎉

@divyanshub024 divyanshub024 added this to the v0.8 milestone Jan 5, 2025
@divyanshub024 divyanshub024 merged commit 3abcdcc into BuildMirai:dev Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants