Musket Bag + Premium Flintlock Ammo #709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the musket bag, gives the musket bag to ranged pirates, allows it to be restocked in a premium restocker, changes how bandoliers work, adds premium flintlock ammo that gets loaded into weapons slightly faster, changes how bullet_time is saved so that one gun can have multiple loading times depending on the bullet, changes the bullet_time for flintlock pistol and musket.
Activates the bandoliers folder in clothing/belt/bandoliers and changes loadout and vendor references of bandoliers.
|
I closed the old branch and opened a new one because my old branch was so horribly out of date. |
BurgerLUA
requested changes
Dec 29, 2024
Brings the PR up to Burger standards
|
Will take a look at this tomorrow. Sorry for the delays. |
BurgerLUA
requested changes
Jan 7, 2025
| @@ -0,0 +1,147 @@ | |||
| /obj/item/clothing/belt/bandoliers | |||
There was a problem hiding this comment.
Don't know how I missed this, but this should be tweaked so it's compatible with already existing instances of bandoliers. Existing code is below.
Variable names that get saved/loaded should be the same, and the type paths should be the same. This is so that people don't lose their ammo when loading a character before the PR gets merged.
The only thing that needs to be changed is stored_bullets (should be stored_shells), and the path should be /obj/item/clothing/belt/bandolier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Why it should be added to the game
I was doing it before because of that one guy on the discord asking for a musket bag and such, but by now I just want this to be merged to be done with it and move on to other requests.