-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hodadako step3: 사용자 전체 정보 조회 #12
Open
hodadako
wants to merge
21
commits into
hodadako
Choose a base branch
from
feature/hodadako_step3
base: hodadako
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EmailRecordRequest 내부에 있던 Save DTO를 단독 레코드로 변경
- Account Entity 추가 - Transaction에 ``createdDate`` 필드 추가
- senderAccount가 아닌 senderName으로 조회하던 부분 수정 - 접근 제어자를 public으로 수정
- 회원이 갖고 있는 계좌 및 해당 계좌를 통한 모든 거래 내역을 조회 - 동기적으로 조회하는 방법과 비동기적으로 조회하는 방법 추가
- Page 관련 쿼리 스트링이 들어오지 않았을 경우를 고려하여 ``@PageableDefault`` 사용 - 기본 정렬을 transactionDate로 하여 계좌와 관계없이 거래 일자로만 순서를 정렬하도록 구현
- database와 일치하기 위해 컬럼 이름 수정 - 필드 이름도 일치하도록 수정
- 기존 Account에서 사용하던 Pageable을 transactionReader에서 사용하도록 변경 - ``@PageDefault``의 정렬이 ``transactionDate``를 기반으로 되어 있어 pageable을 사용할 수 없음
- DTO로 SELECT 할때는 entity가 아니기 때문에 JPQL fetch join 사용할 수 없음
- Gatling를 사용하여 burst와 ramp 두 가지 경우에 대한 테스트를 진행하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현사항
구현설명
##성능 테스트
병렬 조회 시
기본 조회 시
고민 사항