Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed updating of start stop button based on the actions on files in process tile #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed updating of start stop button based on the actions on files in process tile #48

wants to merge 4 commits into from

Conversation

manoj1749
Copy link
Contributor

@manoj1749 manoj1749 commented Feb 24, 2023 •
edited
Loading

closes #47

  • this pr will be solving the issue Start Stop Button Not Getting Updated #47 .
  • fixed this bug by adding the feature to updated the status of start_stop_button from 'Stop All' to 'Start All' whenever we remove the files from process_tile during the process still going on.
working.mp4

@manoj1749 manoj1749 mentioned this pull request Feb 24, 2023
Open
@manoj1749
Copy link
Contributor Author

Heyy @techno-disaster can you look into this pr👀

techno-disaster
techno-disaster reviewed Feb 27, 2023
View reviewed changes
lib/screens/dashboard/components/process_tile.dart
),
TextButton(
onPressed: () {
StartStopButton();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for rebuilding the StartStopButton widget

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work if DashboardState or ProcessState change tho

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on what you are trying to say, I am not able to get you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StartStopButton rebuilds on DashboardBloc and ProcessBloc updates. https://github.com/CCExtractor/ccextractorfluttergui/pull/48/files#diff-1bd4c76f5c4b0d8d3bd1f7757702ba2711e87599cdbd057b4ecc901013279726R19.

Also unsure how calling StartStopButton() rebuilds the original button 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had checked it is not working without StartStopButton();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any changes needed to be done👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I need to test this myself, not really free atm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating any of the following should rebuild it automatically (unless there's some error in the login in StartStopButton.

  • ProcessState
  • DashboardState
  • SettingsState

@manoj1749
Copy link
Contributor Author

Heyy @techno-disaster , do I need to make any changes or anything for this pr?

@manoj1749
Copy link
Contributor Author

Heyy @techno-disaster , it's been long time since I made this pr. Can you look into this once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techno-disaster techno-disaster techno-disaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start Stop Button Not Getting Updated
2 participants
@manoj1749 @techno-disaster