Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task theme change fix #207

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add task theme change fix #207

merged 4 commits into from
Nov 16, 2023

Conversation

its-me-abhishek
Copy link
Contributor

@its-me-abhishek its-me-abhishek commented Nov 16, 2023

Description

Fixed the issue of inconsistency of theme colors on add task screen.

Fixes #204

Screenshots

1
2

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@its-me-abhishek
Copy link
Contributor Author

@Pavel401 Please review my PR

@Pavel401
Copy link
Member

Hey, I saw the changes you have made.

Screenshot_1700124928

The color scheme of the dialog doesn't seem to align with the overall theme. Additionally, the text theme appears to be somewhat inaccurate. In the provided screenshot, it's evident that the text color lacks visibility, and the dialog box color seems to overpower the UI color. I suggest exploring alternative shades to enhance the overall visual experience.

Screenshot 2023-11-16 at 2 09 47 PM

For reference, I came across an example in the Material 3 guidelines, which showcases a more cohesive and visually appealing design. Please consider implementing a similar approach, as demonstrated in the attached image.

@Pavel401
Copy link
Member

@its-me-abhishek Also make sure there are no errors during CI/CD.

@its-me-abhishek
Copy link
Contributor Author

1
2
I have updated these and fixed the CI/CD issues

@Pavel401 Pavel401 merged commit eb9a12b into CCExtractor:main Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Add task screen color/theme doesnot follow dark theme mode
2 participants