Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the deprecated WillPopScope to PopScope #222

Merged
merged 12 commits into from
Dec 16, 2023
Merged

Changed the deprecated WillPopScope to PopScope #222

merged 12 commits into from
Dec 16, 2023

Conversation

its-me-abhishek
Copy link
Contributor

Description

Replaced WillPopScope in task_details

Fixes #221

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@its-me-abhishek
Copy link
Contributor Author

  • Hey @Pavel401 , I am facing an error
    error • The method 'PopScope' isn't defined for the type '_DetailRouteState' • lib/services/task_details.dart:63:12 • undefined_method in the CI
  • I have upgraded the sdk in pubsec.yaml to the latest version so that the users can use PopScope.
  • This error might be due to the version of Flutter that the workflow CI uses.
  • PopScope is usable in Flutter 3.16.4 Dart 3.2.3 as on my system while the CI uses :
    flutter-version: '3.10.5'.

Pavel401
Pavel401 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@Pavel401 Pavel401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Pavel401 Pavel401 merged commit a3beb7a into CCExtractor:main Dec 16, 2023
1 of 2 checks passed
@Pavel401
Copy link
Member

@its-me-abhishek I have updated the flutter version in the workflow file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavel401 Pavel401 Pavel401 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: Replace the deprecated WillPopScope() with PopScope()
2 participants
@its-me-abhishek @Pavel401