Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added toasts for server errors #380

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

rohansen856
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #369

Screenshots

Screenshot from 2024-11-14 23-49-22

video demo:
https://github.com/user-attachments/assets/b2b04c28-8f84-4d88-b8c5-b259fcf15fee

Summary

added toasts in case the http.post request fails in the lib/api_service.dart file. total changes in 2 functions:
completeTask and modifyTaskOnTaskwarrior to add error toast for better user understanding.

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@rohansen856
Copy link
Contributor Author

@BrawlerXull I have added a video demo and a;so refactored the unnecessary file changes as discussed in #379. Thank you.

@BrawlerXull
Copy link
Collaborator

LGTM 🚀

Copy link
Collaborator

@BrawlerXull BrawlerXull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@BrawlerXull BrawlerXull merged commit 8e13287 into CCExtractor:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

modifyTaskOnTaskwarrior fails silently
2 participants