Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added permission request screen #432

Merged
merged 5 commits into from
Jan 26, 2025

Conversation

rohansen856
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #412

  • Edited total of 4 files and added 3 files
  • added new permissions page under lib/app/models folder using get-cli and edited accordingly
  • edited files under routes folder to add the permission screen path
  • modifies the main.dart file so that permissions are not requested at the app start.
  • For Linux, Mac and Windows the screen is skipped using:
    if (Platform.isLinux || Platform.isMacOS || Platform.isWindows) {
      WidgetsBinding.instance.addPostFrameCallback((_) {
        Get.offAllNamed('/home');
      });
      return const SizedBox.shrink();
    }

Replace issue_no with the issue number which is fixed in this PR

Screenshots

Example in linux device:

Screencast.from.2025-01-13.00-07-04.webm

Example in android device:

WhatsApp.Video.2025-01-13.at.12.11.07.AM.mp4

Final UI:

WhatsApp Image 2025-01-12 at 10 38 46 PM (1)

WhatsApp Image 2025-01-12 at 10 42 09 PM

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@rohansen856
Copy link
Contributor Author

rohansen856 commented Jan 12, 2025

*Also updated a test to match the current changes

@rohansen856
Copy link
Contributor Author

rohansen856 commented Jan 12, 2025

@BrawlerXull i have resolved all the test and analyze errors. the 2 tests failing are related to another issue i mentioned here.
This PR is ready for review.
Thanks.

@BrawlerXull
Copy link
Collaborator

I've reviews some changes

@rohansen856
Copy link
Contributor Author

@BrawlerXull I have updated according to all the requirements:

  • Used PermissionManager from lib/app/utils/permissions/permissions_manager.dart instead of custom logic in PermissionController.
  • Made the _buildPermissionSection in permission_view into a separate StatelessWidget

Please let me know if any more refactors needed.

Copy link
Member

@Pavel401 Pavel401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohansen856

@Pavel401 Pavel401 merged commit 94980db into CCExtractor:main Jan 26, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermediary Screen UI: Request for Permissions
3 participants