Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesigned add task dialogue #442

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SGI-CAPP-AT2
Copy link
Contributor

@SGI-CAPP-AT2 SGI-CAPP-AT2 commented Jan 21, 2025

Description

This PR redesigns the Add Task Dialogue to bottom sheet with some of the changes like

  1. Multiple Dates Selection at the time of Task Creation
  2. Tags input changes to have autocomplete
  3. Project input changes with auto complete

Tasks to be done:

  • Add tags support for ccsync
  • Theme Adaption and color scheme

Fixes #384

Screenshots

IMAGE IMAGE
WhatsApp Image 2025-01-21 at 20 06 30_d4cba66f WhatsApp Image 2025-01-21 at 20 06 30_5504937c
WhatsApp Image 2025-01-21 at 20 06 31_f857b84d

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@SGI-CAPP-AT2 SGI-CAPP-AT2 marked this pull request as draft January 21, 2025 14:37
@SGI-CAPP-AT2
Copy link
Contributor Author

SGI-CAPP-AT2 commented Jan 21, 2025

@its-me-abhishek , I am thinking of implementing #441 in this PR which will have only one bottom sheet for both 2.0 and 3.0

@its-me-abhishek
Copy link
Contributor

its-me-abhishek commented Jan 21, 2025

hey! imo separate bottomSheets should be better for differentiation (or you can try using visibility widget along with isTaskcEnabled bool, but please make sure that it does not break something) as CCSync does not support adding dates such as sched, until, wait, etc for tasks. Also, you should look into #441 before doing this (if you are interested in developing that), as yet again the bottomsheet would need to be updated for adding tags functionality.
P.S. The tags functionality has been added to CCSync via this issue

Edit: The screenshots suggest that the theme should also be fixed according to the Color scheme of the app

@SGI-CAPP-AT2
Copy link
Contributor Author

SGI-CAPP-AT2 commented Jan 21, 2025

hey! imo separate bottomSheets should be better for differentiation (or you can try using visibility widget along with isTaskcEnabled bool, but please make sure that it does not break something) as CCSync does not support adding dates such as sched, until, wait, etc for tasks. Also, you should look into #441 before doing this (if you are interested in developing that), as yet again the bottomsheet would need to be updated for adding tags functionality. P.S. The tags functionality has been added to CCSync via this issue

Edit: The screenshots suggest that the theme should also be fixed according to the Color scheme of the app

Yes, I am thinking of implementing #441 by this PR (typo in previous comment wrote 414 instead of 441)
Theme is yet to be done, when #402 will be merged it'll reduce the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Improve Add Dialog
2 participants