Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag support v2 #121

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add tag support v2 #121

merged 4 commits into from
Apr 11, 2024

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau linked an issue Apr 20, 2023 that may be closed by this pull request
Support multiple named discrete dimensions using similar discretizations of the same continuous dimension #95
Closed
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 6 times, most recently from e0f0cdf to 32d80fd Compare April 27, 2023 15:57
@tpadioleau
Copy link
Member Author

tpadioleau commented Apr 27, 2023 •
edited
Loading

From my point of view, contrary to the v1, in this version some free functions hide some implicits (for example when using .uid() on DiscreteElements) and thus should be friend with the Impl structure. These functions used to be member functions in main or v1.

The user can extend the API formed by these functions by implementing new free functions on top of them.

@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from 32d80fd to 3973b5f Compare April 27, 2023 16:26
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 7 times, most recently from e44c252 to 2d3273e Compare June 7, 2023 12:13
This was referenced Jun 15, 2023
Closed
Closed
@jbigot jbigot force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from 2d3273e to f1a423a Compare June 22, 2023 09:39
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from f1a423a to 94a934f Compare June 26, 2023 14:28
@tpadioleau tpadioleau closed this Oct 5, 2023
@tpadioleau tpadioleau reopened this Jan 12, 2024
@tpadioleau tpadioleau marked this pull request as draft January 18, 2024 12:45
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 3 times, most recently from 83c73a6 to 0b6ee91 Compare January 19, 2024 10:30
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 3 times, most recently from e94b23c to 8394587 Compare January 24, 2024 13:33
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 3 times, most recently from 99b4936 to 55a2888 Compare March 28, 2024 19:31
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 4 times, most recently from 8654b5e to b34613e Compare April 3, 2024 16:21
@tpadioleau tpadioleau mentioned this pull request Apr 5, 2024
Merged
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from b34613e to 7810b19 Compare April 6, 2024 14:29
EmilyBourne
EmilyBourne previously approved these changes Apr 8, 2024
View reviewed changes
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from 45b52ca to c9a0d58 Compare April 8, 2024 20:10
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch 3 times, most recently from 42d48bf to b1c770d Compare April 11, 2024 09:28
@tpadioleau tpadioleau force-pushed the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch from b1c770d to 66ad4e0 Compare April 11, 2024 09:29
@tpadioleau tpadioleau merged commit d652df8 into main Apr 11, 2024
43 checks passed
@tpadioleau tpadioleau deleted the 95-support-multiple-named-discrete-dimensions-using-similar-discretizations-of-the-same-continuous-dimension-v2 branch April 11, 2024 10:14
@EmilyBourne EmilyBourne mentioned this pull request Apr 18, 2024
Closed
@EmilyBourne EmilyBourne mentioned this pull request Apr 25, 2024
Merged
@EmilyBourne EmilyBourne mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyBourne EmilyBourne EmilyBourne left review comments

@jbigot jbigot jbigot left review comments

Assignees

@tpadioleau tpadioleau

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple named discrete dimensions using similar discretizations of the same continuous dimension
3 participants
@tpadioleau @jbigot @EmilyBourne