Additional comments and changed variable names in heat equation example #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-m-h
force-pushed
the
example_heat_equation_additional_comments
branch
from
5536c92 to
8a9c803
Compare
tpadioleau
reviewed
Jan 5, 2024
There was a problem hiding this comment.
@alex-m-h Does it still answer your questions with these changes ?
tpadioleau
force-pushed
the
example_heat_equation_additional_comments
branch
from
9d7de3d to
0eb28aa
Compare
tpadioleau
reviewed
Jan 9, 2024
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
tpadioleau
force-pushed
the
example_heat_equation_additional_comments
branch
from
50a06e6 to
6f8e91f
Compare
tpadioleau
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments were added based on answers from Thomas and two variable names were changed for clarity in the heat equation example.