Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant cmake logic #660

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Avoid redundant cmake logic #660

merged 2 commits into from
Oct 17, 2024

Conversation

tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Oct 4, 2024 •
edited
Loading

Factorize configuration of vendor dependencies into a single file. This avoids to repeat the logic for EMBEDDED and AUTO configuration options. Each macro is called ddc_configure_*.

@tpadioleau tpadioleau self-assigned this Oct 4, 2024
@tpadioleau tpadioleau changed the base branch from main to tpadiole-rebase-kokkos-fft October 4, 2024 16:26
@tpadioleau tpadioleau force-pushed the avoid-redundant-cmake-logic branch 2 times, most recently from 1bc195b to 48e5fb1 Compare October 8, 2024 06:39
@tpadioleau tpadioleau force-pushed the tpadiole-rebase-kokkos-fft branch from f816750 to 8af2ceb Compare October 8, 2024 06:51
Base automatically changed from tpadiole-rebase-kokkos-fft to main October 8, 2024 08:24
@tpadioleau tpadioleau force-pushed the avoid-redundant-cmake-logic branch 2 times, most recently from bae35c8 to 923886c Compare October 13, 2024 21:14
@tpadioleau tpadioleau force-pushed the avoid-redundant-cmake-logic branch 3 times, most recently from a438f29 to 3a2b7ce Compare October 16, 2024 12:29
@tpadioleau tpadioleau marked this pull request as ready for review October 16, 2024 19:07
@tpadioleau tpadioleau force-pushed the avoid-redundant-cmake-logic branch from 3a2b7ce to 6cc13c8 Compare October 16, 2024 19:07
@science-enthusiast
Copy link

I looked at the commits. I don't know the details but the refactoring looks reasonable.

@tpadioleau
Copy link
Member Author

I looked at the commits. I don't know the details but the refactoring looks reasonable.

thanks a lot

@tpadioleau tpadioleau merged commit 579427b into main Oct 17, 2024
56 checks passed
@tpadioleau tpadioleau deleted the avoid-redundant-cmake-logic branch October 17, 2024 14:40
@tpadioleau tpadioleau mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@science-enthusiast science-enthusiast science-enthusiast approved these changes

Assignees

@tpadioleau tpadioleau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpadioleau @science-enthusiast