Remove definition MDSPAN_USE_PAREN_OPERATOR=1 from DDC target #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpadioleau
force-pushed
the
676-do-not-force-mdspan_use_paren_operator=1
branch
2 times, most recently
from
5f4dd1f to
6a1439e
Compare
tpadioleau
force-pushed
the
676-do-not-force-mdspan_use_paren_operator=1
branch
from
6a1439e to
bb724ee
Compare
yasahi-hpc
approved these changes
Nov 5, 2024
yasahi-hpc
previously approved these changes
Nov 5, 2024
|
Any preference between introducing a macro or a function ? |
I think macro is good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDC should not force dependent projects to use
MDSPAN_USE_PAREN_OPERATOR=1. Moreover this variable only makes sense in the Kokkos implementation of mdspan. A compiler provided implementation will likely not provide this variable neither the function call operator, see cppref.In this PR, DDC adapts to the mdspan implementation, defaulting on using the bracket operator.
Note that there is a bug with llvm 15/16, see the reproducer on godbolt. It has been reported on the mdspan repo, see here.
The two first commits provide alternative implementations that correctly call mdspan either with: