Improve cmake workaround for rocm <6 #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpadioleau
force-pushed
the
improve-cmake-workaround-rocm
branch
from
2210d9b to
e8e40bb
Compare
tpadioleau
force-pushed
the
improve-cmake-workaround-rocm
branch
from
e8e40bb to
6e9fa5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
cmake_minimum_required(VERSION 3.3)insidehip-config.cmakealong withinclude(CMakeFindDependencyMacro)redefines the macrofind_dependencywith a behavior following theOLDpolicyCMP0074.The trick in the PR is to redefine the macro each time we plan to use it. It slightly improve the situation.