-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example mesh_3D_gray_vtk_image #7824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Less
or More
actually depends on the input data.
Using More
is the default behavior when using isovalue
only, and using Less
gives another example. This should be better documented
Successfully tested in CGAL-6.0-Ic-122 |
@janetournois @ange-clement As far as I understand, that pull-request is debated. I will not merge it, even if it was tested successfully. |
@janetournois what is the status of this PR? |
This modifies the example of Mesh_3 to make it work with different data sets, and it does not bring any new info or feature, so imho it can be closed. |
What about adding an option in the parameter to pick less or more? |
30689f0
to
335f9b3
Compare
Good idea @sloriot ! |
which is why the default is true |
Successfully tested in CGAL 6.1-Ic-14 |
Summary of Changes
Fixes example mesh_3D_gray_vtk_image.
Changed : Meshing all value under isovalue --> Meshing all values over isovalue.
Release Management