New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMP: Non-rigid mesh registration #8329

Open

soesau wants to merge 45 commits into CGAL:master from soesau:PMP-Non_rigid_registration-GF

Member

soesau commented Jul 2, 2024 •

edited by sloriot

Loading

Summary of Changes

WIP

Non-rigid mesh registration based on:
https://vgl.ict.usc.edu/Research/NonRigidRegistration/MODERN%20TECHNIQUES%20AND%20APPLICATIONS%20FOR%20REAL-TIME%20NON-RIGID%20REGISTRATION.pdf
https://www.comp.nus.edu.sg/~lowkl/publications/lowk_point-to-plane_icp_techrep.pdf

TODO:

check size (for sloriot)

Release Management

Affected package(s): PMP
Feature/Small Feature (if any): small feature -- Pre-approved 2024/11/21
Link to compiled documentation (obligatory for small feature) user manual ref manual
License and copyright ownership: Inria/GeometryFactory?

soesau added 2 commits

July 2, 2024 10:39


          Non-rigid mesh registration

4c41bda


          added a preliminary license header

97ce59f

soesau mentioned this pull request

Non-rigid Iterative Closest Point (N-ICP) #7674

Closed

soesau added 3 commits

July 2, 2024 11:30


          fixes for CI

d1de633


          revert Point_set_3 dependency

2f2551b


          working on registration and doc

b73ce3e

Member Author

soesau commented Aug 5, 2024

/build:v0

github-actions bot commented Aug 5, 2024

There was an error while building the doc:

https://github.com/CGAL/cgal/actions/runs/10250523837


          doc fix

db8ffbe

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

STL_Extension/include/CGAL/STL_Extension/internal/parameters_interface.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved


          pass on doc

d981129

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved


          update on doc

ba01e61


          documentation of Deformation_algorithm_tag

37d66b7

albert-github reviewed

View reviewed changes

Surface_mesh_deformation/include/CGAL/Surface_mesh_deformation.h Outdated Show resolved Hide resolved

soesau added 2 commits

November 21, 2024 12:19


          doc fix

d1059ac


          fixing vertex normal rotation after registration

608de95

sloriot added the pre-approved label

soesau added 3 commits

November 21, 2024 15:39


          doc updates

ff97fb9


          doc of geom_traits

09bbae9


          fixed warning

1f897b8

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_mesh_processing.txt Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

...gon_mesh_processing/examples/Polygon_mesh_processing/non_rigid_mesh_registration_example.cpp Outdated Show resolved Hide resolved

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved


          Update Polygon_mesh_processing/doc/Polygon_mesh_processing/Polygon_me…

0a03248

…sh_processing.txt

Co-authored-by: Andreas Fabri <[email protected]>

afabri reviewed

View reviewed changes

Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/non_rigid_mesh_registration.h Outdated Show resolved Hide resolved

sloriot added Tested and removed Not yet approved Under Testing labels

Member

sloriot commented Dec 4, 2024

Successfully tested in CGAL-6.1-Ic-33

sloriot added the TODO label

Member

sloriot commented Dec 9, 2024

@soesau you have some comments left unanswered


          renaming maximum_matching_distance to maximal_matching_distance

fe9e8d9

more useful default value for maximal_matching_distance
removing former arap implementation
more changes from review

github-actions bot removed the Tested label

github-actions bot commented Dec 10, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

soesau added 2 commits

December 10, 2024 13:29


          Merge branch 'master' into PMP-Non_rigid_registration-GF

b2399b9


          CI fix

c8bb801

MaelRL added Accepted small feature Work in progress and removed pre-approved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted small feature Pkg::PMP Small feature TODO Work in progress