Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KSP] Exact intersections bugfix #8631

Merged
merged 8 commits into from
Dec 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
using std::isnan
  • Loading branch information
soesau committed Nov 28, 2024
commit d01979f5ef8fe89126818ca8737a4c34fbda13b4
4 changes: 2 additions & 2 deletions Kinetic_space_partition/include/CGAL/KSP_3/Initializer.h
Original file line number Diff line number Diff line change
@@ -493,7 +493,7 @@ class Initializer {

typename Intersection_graph::Kinetic_interval& kinetic_interval = m_data.igraph().kinetic_interval(e, sp_idx);
crossing_iedges.push_back(e);
if (emin > s || (min_speed != min_speed)) {
if (emin > s || std::isnan(min_speed)) {
typename Intersection_kernel::FT bary_edge_exact = (emin - s) / (t - s);
FT bary_edge = from_exact((emin - s) / (t - s));
CGAL_assertion(bary_edge_exact >= 0);
@@ -505,7 +505,7 @@ class Initializer {
kinetic_interval.push_back(std::pair<FT, FT>(0, 0));
}

if (t > emax || (max_speed != max_speed)) {
if (t > emax || std::isnan(max_speed)) {
typename Intersection_kernel::FT bary_edge_exact = (emax - s) / (t - s);
FT bary_edge = from_exact((emax - s) / (t - s));
CGAL_assertion(0 <= bary_edge_exact && bary_edge_exact <= 1);