Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used std::vector instead of c-style arrays for point storage. #8709

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

SharonIV0x86
Copy link
Contributor

Updated two CGAL examples to use std::vector instead of plain C-style arrays for storing points.

Few more examples can be improved the same way to use std::vector and avoid usage of c-style arrays.

  • Min_annulus_d
  • Min_circle_2
  • Min_ellipse
  • Min_sphere_d

@lrineau
Copy link
Member

lrineau commented Jan 22, 2025

In case the size is known at compile time, please use std::array<Point, n> instead of std::vector<Point>.

@SharonIV0x86
Copy link
Contributor Author

In case the size is known at compile time, please use std::array<Point, n> instead of std::vector<Point>.

Nice suggestion, initially i thought of using std::array but dropped the idea, will work on it.

SharonIV0x86 and others added 2 commits January 26, 2025 17:54
…ng_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp
@SharonIV0x86 SharonIV0x86 requested a review from MaelRL January 28, 2025 13:42
@MaelRL MaelRL added this to the 6.1-beta milestone Jan 29, 2025
@lrineau lrineau added the CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL label Jan 29, 2025
@SharonIV0x86
Copy link
Contributor Author

@lrineau The email address to send the signed CLA is not mentioned in the agreement available at https://www.cgal.org/CLA/CLA-GF.html. Could you please confirm if I can send the signed agreement to [email protected]?

@SharonIV0x86
Copy link
Contributor Author

@lrineau The email address to send the signed CLA is not mentioned in the agreement available at https://www.cgal.org/CLA/CLA-GF.html. Could you please confirm if I can send the signed agreement to [email protected]?

@sloriot How should i proceed?

@lrineau
Copy link
Member

lrineau commented Feb 4, 2025

It is unclear for us (CGAL developers), if that kind of contribution (that modifies only examples), requires a contribution agreement.

@SharonIV0x86
Copy link
Contributor Author

SharonIV0x86 commented Feb 4, 2025

It is unclear for us (CGAL developers), if that kind of contribution (that modifies only examples), requires a contribution agreement.

In future it might be required, because i have a few more idea in mind that i'd like to contribute, so if you can just direct me should i proceed with this or? #8709 (comment) However, I am happy to proceed with any way.

@sloriot
Copy link
Member

sloriot commented Feb 4, 2025

@lrineau The email address to send the signed CLA is not mentioned in the agreement available at https://www.cgal.org/CLA/CLA-GF.html. Could you please confirm if I can send the signed agreement to [email protected]?

You can send it to [email protected], thanks for the contribution.

@sloriot
Copy link
Member

sloriot commented Feb 4, 2025

Successfully tested in CGAL-6.1-Ic-78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL Enhancement Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants