-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used std::vector instead of c-style arrays for point storage. #8709
base: master
Are you sure you want to change the base?
Conversation
In case the size is known at compile time, please use |
Nice suggestion, initially i thought of using |
Bounding_volumes/examples/Min_circle_2/min_circle_homogeneous_2.cpp
Outdated
Show resolved
Hide resolved
Bounding_volumes/examples/Min_circle_2/min_circle_homogeneous_2.cpp
Outdated
Show resolved
Hide resolved
…ng_volumes (1)min_annulus_d_fast_exact.cpp (2)min_annulus_d.cpp (3)min_ellipse_2.cpp (4)min_sphere_3.cpp (5)min_sphere_homogenous_3.cpp
Bounding_volumes/examples/Min_annulus_d/min_annulus_d_fast_exact.cpp
Outdated
Show resolved
Hide resolved
@lrineau The email address to send the signed CLA is not mentioned in the agreement available at https://www.cgal.org/CLA/CLA-GF.html. Could you please confirm if I can send the signed agreement to [email protected]? |
@sloriot How should i proceed? |
It is unclear for us (CGAL developers), if that kind of contribution (that modifies only examples), requires a contribution agreement. |
In future it might be required, because i have a few more idea in mind that i'd like to contribute, so if you can just direct me should i proceed with this or? #8709 (comment) However, I am happy to proceed with any way. |
You can send it to [email protected], thanks for the contribution. |
Successfully tested in CGAL-6.1-Ic-78 |
Updated two CGAL examples to use
std::vector
instead of plain C-style arrays for storing points.Few more examples can be improved the same way to use
std::vector
and avoid usage of c-style arrays.