Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding features to the OpenTitanUart driver #277

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

HU90m
Copy link
Collaborator

@HU90m HU90m commented Jul 26, 2024

I fleshed out the OpenTitan UART driver a little while working on lowRISC/sonata-software#26. I don't think this is quite ready to be merged yet; opening this purely for visibility.

@davidchisnall
Copy link
Collaborator

There's a bunch of stuff in here that's just improving the existing code, rather than adding new things. It would be great to have those merged soon (I don't anticipate problems with the other bits either).

@HU90m HU90m marked this pull request as ready for review July 30, 2024 13:41
@HU90m
Copy link
Collaborator Author

HU90m commented Jul 30, 2024

There's a bunch of stuff in here that's just improving the existing code, rather than adding new things. It would be great to have those merged soon (I don't anticipate problems with the other bits either).

👍 Rebased onto #278 (comment) and marked as ready for review.

@davidchisnall
Copy link
Collaborator

We probably need to document somewhere that this changes the behaviour of stderr, for anyone who is using stdio.h.

@HU90m
Copy link
Collaborator Author

HU90m commented Jul 30, 2024

We probably need to document somewhere that this changes the behaviour of stderr, for anyone who is using stdio.h.

Where would be a good place to document this change?

@davidchisnall
Copy link
Collaborator

Good question. A blog post maybe, and possibly in the Sonata bit of the Getting Started doc?

@davidchisnall davidchisnall enabled auto-merge (rebase) July 30, 2024 15:46
@davidchisnall davidchisnall merged commit 9baefdb into CHERIoT-Platform:main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants