-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonata Pinmux driver #360
Sonata Pinmux driver #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hugo, this looks correct to me from a code review.
I think in the case of the Pinmux it's best to make sure sink names match the canonical name used documentation, RTL and schematic. The sinks are enum classes, so breaking the code style shouldn't cause much confusion here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like platform-pinmux.hh is generated from sonata-system's platform-pinmux.hh.tpl via its top_gen. It'd be good to...
- have a comment to that effect in the file
- update the
.hh.tpl
in light of the changes made here (NOLINT
, names of some function arguments and locals, &c).
FWIW, I ran git diff --word-diff
having clobbered sonata-system
v0.3-403-g658a741
's sw/cheri/common/platform-pinmux.hh
with the one from this PR; that might be the easiest way to find the requisite changes to the template?
I have not attempted to validate that top_gen
is consistent between the RTL and C++ it generates, much preferring to merely assume so. :)
↑ rebased onto main, ↓ added comment pointing to what generates the file. |
Thanks for doing that. One nit aside, this LGTM. |
lowRISC/sonata-system#376 is now merged. |
Want to update the |
The This PR has already been updated with the updated with the latest output, only run through clang-format with the CHERIoT settings. |
I missed in review, but this seems to have an Apache license. Is it possible to relicense to match the rest of the repository? |
A driver for Sonata v1.0's Pinmux