Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document stack high water mark. #49

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Document stack high water mark. #49

merged 1 commit into from
Apr 4, 2024

Conversation

rmn30
Copy link
Collaborator

@rmn30 rmn30 commented Apr 2, 2024

Make it explicitly 16-byte aligned and point out the unaligned write spanning mshwmb corner case, which we do not require hardware to handle.

Fixes #15.

Copy link
Contributor

@kliuMsft kliuMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rmn30 rmn30 force-pushed the shwm branch 2 times, most recently from 070c012 to eda7e45 Compare April 4, 2024 10:51
Make it explicitly 16-byte aligned and point out the unaligned write spanning mshwmb corner case, which we do not require hardware to handle.

Fixes #15.
@rmn30 rmn30 merged commit c255ddc into main Apr 4, 2024
3 checks passed
@rmn30 rmn30 deleted the shwm branch April 4, 2024 11:15
rmn30 pushed a commit to CHERIoT-Platform/cheriot-rtos that referenced this pull request Apr 4, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no
longer need to mask it in the switcher.

See CHERIoT-Platform/cheriot-sail#49
@marnovandermaas
Copy link
Contributor

Thanks for making this change!

davidchisnall pushed a commit to CHERIoT-Platform/cheriot-rtos that referenced this pull request Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no
longer need to mask it in the switcher.

See CHERIoT-Platform/cheriot-sail#49
davidchisnall pushed a commit to CHERIoT-Platform/cheriot-rtos that referenced this pull request Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no
longer need to mask it in the switcher.

See CHERIoT-Platform/cheriot-sail#49
davidchisnall pushed a commit to CHERIoT-Platform/cheriot-rtos that referenced this pull request Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no
longer need to mask it in the switcher.

See CHERIoT-Platform/cheriot-sail#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack high water mark may not be updated correctly for writes spanning MSHWMB
4 participants