-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document stack high water mark. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kliuMsft
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
rmn30
force-pushed
the
shwm
branch
2 times, most recently
from
April 4, 2024 10:51
070c012
to
eda7e45
Compare
Make it explicitly 16-byte aligned and point out the unaligned write spanning mshwmb corner case, which we do not require hardware to handle. Fixes #15.
rmn30
pushed a commit
to CHERIoT-Platform/cheriot-rtos
that referenced
this pull request
Apr 4, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no longer need to mask it in the switcher. See CHERIoT-Platform/cheriot-sail#49
Thanks for making this change! |
davidchisnall
pushed a commit
to CHERIoT-Platform/cheriot-rtos
that referenced
this pull request
Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no longer need to mask it in the switcher. See CHERIoT-Platform/cheriot-sail#49
davidchisnall
pushed a commit
to CHERIoT-Platform/cheriot-rtos
that referenced
this pull request
Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no longer need to mask it in the switcher. See CHERIoT-Platform/cheriot-sail#49
davidchisnall
pushed a commit
to CHERIoT-Platform/cheriot-rtos
that referenced
this pull request
Apr 5, 2024
Now that the stack high water mark is explicilty 16-byte aligned we no longer need to mask it in the switcher. See CHERIoT-Platform/cheriot-sail#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it explicitly 16-byte aligned and point out the unaligned write spanning mshwmb corner case, which we do not require hardware to handle.
Fixes #15.