Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the sail container for builds (hopefully faster)! #62

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

davidchisnall
Copy link
Collaborator

No description provided.

@davidchisnall davidchisnall force-pushed the smaller-ci branch 9 times, most recently from e702060 to 60514a0 Compare July 16, 2024 16:01
Copy link
Collaborator

@rmn30 rmn30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly saves about 5 minutes. Could we make it even faster by including the latex dependencies, or does that make the container too huge?

@davidchisnall
Copy link
Collaborator Author

Adding LaTeX adds around 40 seconds to the container deployment time, which saves time here but costs it in the dev container, so I've made a second container image that includes the LaTeX bits. This one is built from the first, so they share the same layers for the sail bits.

@davidchisnall davidchisnall merged commit 1a107c1 into main Jul 16, 2024
3 checks passed
@davidchisnall davidchisnall deleted the smaller-ci branch July 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants