Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing CSeal to set otype to any value between 0 and 7 for EX capabilities #68

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

kliuMsft
Copy link
Contributor

Previously we had otype 4 and 5 being reserved and CSeal can't seal to those types (will clear tag). With PR#54, 4 and 5 are now defined as backward sentries so it seems logical to allow CSeal to create those otypes.

Copy link
Member

@nwf nwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Keeping this as an enumerated match statement is chatty, but the commentary is nice.

@rmn30 rmn30 merged commit 43dead9 into CHERIoT-Platform:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants